Re-add deprecated function editAttributeFieldAttachment.getFromCache
#692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until 0.7.0, we had a public class method exposed on editAttributeFieldAttachment called `getFromCache`, which was being used elsewhere to hook into attachment preview rendering and other useful attachment needs. (For example, the Image Shortcake plugin was using it to pull alt, caption, and other values from the attachment to prepopulate those fields.) I think it would still be helpful to expose this cache, even though it isn't needed anymore internally, just because it costs next to nothing to have in place, and is useful for integration with other fields.
Prevent errors where the updateCache callback is triggered before setValue is called.
We don't really have to start our own js object store to cache these attachments, because wp.media already stores it's own client-side cache. This removes the addToCache function, and just swaps out getFromCache to use wp.media.attachment under the hood.
|
I'd love to get a review of this, and get this merged back into the plugin. This seems like the simplest thing I can think to do, to restore the |
|
Punting on this for now, since I don't see this method being used anywhere other than in Image Shortcake, and it's easier to update that plugin than to maintain a deprecated method here indefinitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until #508, we had a public class method exposed on
editAttributeFieldAttachmentcalledgetFromCache(), which was being used elsewhere to hook into attachment preview rendering and other useful attachment needs. (For example, the Image Shortcake plugin uses it to pull alt, caption, and other values from the attachment and prepopulate those fields on the image shortcode.)I think it would still be helpful to expose this cache, even though it isn't needed anymore internally, just because it costs next to nothing to have in place, and is useful for integration with other fields.